Skip to content

Revert "Switch self profile to use HW counters instead of walltime" #1700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2023
Merged

Revert "Switch self profile to use HW counters instead of walltime" #1700

merged 1 commit into from
Aug 12, 2023

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Aug 12, 2023

Reverts #1647.

It caused problems:

expected success, got exit status: 101
    
    stderr=   Compiling issue-32278-big-array-of-strings v0.1.0 (/tmp/.tmpzjBJWE)
    thread 'opt 2dcd9fdmsw04s0mo' panicked at /cargo/registry/src/index.crates.io-6f17d22bba15001f/measureme-10.1.1/src/raw_event.rs:55:9:
    assertion failed: start <= end
    stack backtrace:

@Kobzol Kobzol requested a review from Mark-Simulacrum August 12, 2023 13:42
@Kobzol Kobzol mentioned this pull request Aug 12, 2023
Open
@Mark-Simulacrum Mark-Simulacrum enabled auto-merge (squash) August 12, 2023 13:46
@Mark-Simulacrum Mark-Simulacrum merged commit a95bee1 into master Aug 12, 2023
@Mark-Simulacrum Mark-Simulacrum deleted the revert-1647-self-profile-hw-counters branch August 12, 2023 13:49
@Kobzol Kobzol mentioned this pull request Aug 12, 2023
Merged
@Kobzol Kobzol mentioned this pull request Oct 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kobzol @Mark-Simulacrum